Skip to content

IBX-8175: OpenAPI compatible move user group endpoint #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Jul 24, 2024
Merged

IBX-8175: OpenAPI compatible move user group endpoint #108

merged 33 commits into from
Jul 24, 2024

Conversation

@barw4
Copy link
Contributor

@barw4 barw4 commented Jun 24, 2024 •
edited
Loading

🎫 Issue IBX-8175

Related PRs:

#107

Description:

The new endpoint follows the given specification:

POST /api/ibexa/v2/user/groups/1/5/235
Content-Type: application/vnd.ibexa.api.MoveUserGroupInput+json
Accept: application/json
{
    "MoveUserGroupInput": {
        "destination": "/1/5/14"
    }
}

Documentation:

TBD

@barw4 barw4 added Feature New feature request Ready for review labels Jun 24, 2024
@barw4 barw4 self-assigned this Jun 24, 2024
@barw4 barw4 requested a review from a team June 24, 2024 16:37
@barw4 barw4 force-pushed the ibx-8180-swap-location-endpoint-OpenAPI branch from 3268d62 to 55e48bf Compare June 27, 2024 16:25
@barw4 barw4 force-pushed the ibx-8175-move-user-group-endpoint-OpenAPI branch 2 times, most recently from dd2d5bb to 2d384c9 Compare June 28, 2024 08:47
@barw4 barw4 force-pushed the ibx-8180-swap-location-endpoint-OpenAPI branch from 62e73b9 to 8abbae4 Compare June 28, 2024 14:40
@barw4 barw4 force-pushed the ibx-8175-move-user-group-endpoint-OpenAPI branch from 2d384c9 to f3f8a47 Compare June 28, 2024 14:42
konradoboza
konradoboza approved these changes Jul 1, 2024
View reviewed changes
@konradoboza konradoboza requested a review from a team July 1, 2024 07:20
@barw4 barw4 force-pushed the ibx-8180-swap-location-endpoint-OpenAPI branch from 6969142 to 4297243 Compare July 2, 2024 22:21
@webhdx webhdx requested a review from a team July 3, 2024 07:35
@barw4 barw4 force-pushed the ibx-8180-swap-location-endpoint-OpenAPI branch from 0227bcc to 989b2f1 Compare July 16, 2024 07:46
Base automatically changed from ibx-8180-swap-location-endpoint-OpenAPI to main July 17, 2024 09:11
@barw4 barw4 force-pushed the ibx-8175-move-user-group-endpoint-OpenAPI branch from b53ad36 to 67fac58 Compare July 17, 2024 12:33
@micszo micszo self-assigned this Jul 18, 2024
micszo
micszo requested changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here also 404 is returned instead of 403 when destination does not exist. :)

ref. https://doc.ibexa.co/en/latest/api/rest_api/rest_api_reference/rest_api_reference.html#managing-users-move-user-group

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@barw4 barw4 requested a review from micszo July 23, 2024 20:12
micszo
micszo approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on Ibexa Commerce 5.0.x-dev.

@micszo micszo removed their assignment Jul 24, 2024
@Steveb-p Steveb-p merged commit 49748a4 into main Jul 24, 2024
@Steveb-p Steveb-p deleted the ibx-8175-move-user-group-endpoint-OpenAPI branch July 24, 2024 16:04
ezrobot pushed a commit that referenced this pull request Dec 11, 2024
@glye
IBX-9321: Bumped GH action versions (#108)
be3ca7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@micszo micszo micszo approved these changes

@konradoboza konradoboza konradoboza approved these changes

+1 more reviewer

@webhdx webhdx webhdx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Steveb-p Steveb-p

@alongosz alongosz

@tischsoic tischsoic

@barw4 barw4

Labels

Feature New feature request QA approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@barw4 @webhdx @micszo @konradoboza @Steveb-p @alongosz @tischsoic